feat: add-response-model #64

dreinon · 2022-01-03T15:56:33Z

No description provided.

anand2312

A quick first review, a few return annotations are missing

postgrest_py/exceptions.py

postgrest_py/base_request_builder.py

Co-authored-by: Anand <[email protected]>

codecov · 2022-01-04T18:27:32Z

Codecov Report

Merging #64 (11399b9) into master (e190621) will increase coverage by 1.45%.
The diff coverage is 89.90%.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   88.62%   90.08%   +1.45%     
==========================================
  Files          21       22       +1     
  Lines         686      867     +181     
==========================================
+ Hits          608      781     +173     
- Misses         78       86       +8

Impacted Files	Coverage Δ
postgrest_py/exceptions.py	`43.47% <43.47%> (ø)`
postgrest_py/_sync/request_builder.py	`88.88% <60.00%> (-6.24%)`	⬇️
postgrest_py/_async/request_builder.py	`89.13% <63.63%> (-6.00%)`	⬇️
postgrest_py/_async/client.py	`73.52% <100.00%> (ø)`
postgrest_py/base_request_builder.py	`76.04% <100.00%> (+11.46%)`	⬆️
tests/_async/test_request_builder.py	`100.00% <100.00%> (ø)`
tests/_sync/test_request_builder.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e190621...11399b9. Read the comment docs.

postgrest_py/_async/request_builder.py

postgrest_py/base_request_builder.py

postgrest_py/exceptions.py

* initial commit * tests: add fixtures for APIResponse * tests: [WIP] Test methods that don't interact with RequestResponse * tests: replace builtin type by typing type and add type annotations * tests: add requests Response fixtures * chore: change return order to improve readability * tests: add tests for left methods Co-authored-by: Joel Lee <[email protected]> Co-authored-by: Dani Reinón <[email protected]>

anand2312

This looks good to me 🚀
Nitpick: What do you think about making the classmethods/staticmethods on the APIResponse private (adding a leading _)

sourcery-ai · 2022-01-28T14:19:47Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 1.93%.

Quality metrics	Before	After	Change
Complexity	0.51 ⭐	0.30 ⭐	-0.21 👍
Method Length	27.16 ⭐	23.89 ⭐	-3.27 👍
Working memory	5.41 ⭐	4.96 ⭐	-0.45 👍
Quality	89.43% ⭐	91.36% ⭐	1.93% 👍

Other metrics	Before	After	Change
Lines	691	1032	341

Changed files	Quality Before	Quality After	Quality Change
postgrest_py/base_request_builder.py	86.70% ⭐	88.74% ⭐	2.04% 👍
postgrest_py/_async/client.py	92.94% ⭐	92.94% ⭐	0.00%
postgrest_py/_async/request_builder.py	88.17% ⭐	88.32% ⭐	0.15% 👍
postgrest_py/_sync/request_builder.py	88.18% ⭐	88.35% ⭐	0.17% 👍
tests/_async/test_request_builder.py	92.64% ⭐	93.99% ⭐	1.35% 👍
tests/_sync/test_request_builder.py	92.64% ⭐	93.99% ⭐	1.35% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
tests/_async/test_request_builder.py	request_response_with_data	0 ⭐	31 ⭐	10 😞	79.58% ⭐	Extract out complex expressions
tests/_sync/test_request_builder.py	request_response_with_data	0 ⭐	31 ⭐	10 😞	79.58% ⭐	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

dreinon · 2022-01-28T14:20:02Z

This looks good to me 🚀
Nitpick: What do you think about making the classmethods/staticmethods on the APIResponse private (adding a leading _)

@anand2312 Done!

Dani Reinón added 3 commits January 3, 2022 16:54

add poetry dependency

c99d7fb

create APIResponse model

e911222

return APIResponse model in execute method

315a303

dreinon requested review from anand2312, J0 and leynier January 3, 2022 15:57

Dani Reinón added 10 commits January 3, 2022 22:35

sort imports

e6310c5

mypy bug workaround (python/mypy#9319)

790811f

split logic, validate error existance and better type APIResponse

54df5b2

Implement APIError

c6a3f25

add missing black config in pre-commit config

df86617

type APIError properties

3708992

fix: rm unused code and use returning param in update

032a221

refactor: reorder lines

425a1c6

chore: Merge branch 'master' into add-response-model

1972db1

chore: rebuild sync

d0638b4

dreinon marked this pull request as ready for review January 4, 2022 17:53

Dani Reinón added 3 commits January 4, 2022 18:57

chore: rebuild poetry.lock

b2eb3ac

fix: remove wrong parameter

bddf023

chore: format

920b3e2

anand2312 reviewed Jan 4, 2022

View reviewed changes

postgrest_py/exceptions.py Outdated Show resolved Hide resolved

postgrest_py/exceptions.py Outdated Show resolved Hide resolved

postgrest_py/base_request_builder.py Outdated Show resolved Hide resolved

dreinon and others added 4 commits January 4, 2022 19:17

Chore: add missing return types

8a7cce5

Co-authored-by: Anand <[email protected]>

chore: replace builtin dict by Dict to support python < 3.9

6dbd5cb

chore: update precommit hooks

c569b2a

chore: apply format

aea8dc4

dreinon mentioned this pull request Jan 6, 2022

Please provide more info on return types from execute supabase/supabase-py#115

Closed

leynier suggested changes Jan 7, 2022

View reviewed changes

Dani Reinón added 2 commits January 9, 2022 02:03

update return type in execute method

afdd725

use relative import

6c9448c

Dani Reinón added 2 commits January 9, 2022 02:06

add link to mypy issue

2ecbeca

switch super init by class init to avoid future errors

3df240b

dreinon requested a review from leynier January 9, 2022 01:10

Dani Reinón added 2 commits January 13, 2022 20:50

chore: apply future annotations notation to return

2a806b2

chore: rebuild sync

54ade70

J0 mentioned this pull request Jan 15, 2022

Add tests for response model #74

Merged

dreinon force-pushed the add-response-model branch from 6233ae7 to 2df9d14 Compare January 27, 2022 23:22

Merge branch 'master' into add-response-model

4da9fe4

dreinon requested review from anand2312 and lqmanh January 27, 2022 23:24

chore: modify ValueError with ValidationError

cfe8e38

anand2312 reviewed Jan 28, 2022

View reviewed changes

leynier approved these changes Jan 28, 2022

View reviewed changes

chore: add "_" to internal methods

11399b9

dreinon merged commit 07ef4d4 into master Jan 28, 2022

dreinon changed the title ~~Add-response-model~~ feat: add-response-model Jan 28, 2022

anand2312 deleted the add-response-model branch April 13, 2022 17:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add-response-model #64

feat: add-response-model #64

dreinon commented Jan 3, 2022 •

edited

Loading

anand2312 left a comment

codecov bot commented Jan 4, 2022 •

edited

Loading

anand2312 left a comment

sourcery-ai bot commented Jan 28, 2022

dreinon commented Jan 28, 2022

feat: add-response-model #64

feat: add-response-model #64

Conversation

dreinon commented Jan 3, 2022 • edited Loading

anand2312 left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 4, 2022 • edited Loading

Codecov Report

anand2312 left a comment

Choose a reason for hiding this comment

sourcery-ai bot commented Jan 28, 2022

Sourcery Code Quality Report

Legend and Explanation

dreinon commented Jan 28, 2022

dreinon commented Jan 3, 2022 •

edited

Loading

codecov bot commented Jan 4, 2022 •

edited

Loading