Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test async timer #297

Merged
merged 2 commits into from
Apr 1, 2025
Merged

Test async timer #297

merged 2 commits into from
Apr 1, 2025

Conversation

olirice
Copy link
Contributor

@olirice olirice commented Apr 1, 2025

What kind of change does this PR introduce?

Adds tests for async timer to get coverage over 80%

mansueli
mansueli suggested changes Apr 1, 2025
View reviewed changes
Copy link
Member

@mansueli mansueli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's failing CI/CD

@grdsdev grdsdev merged commit f3ae750 into main Apr 1, 2025
10 checks passed
@grdsdev grdsdev deleted the or/test-async-timer branch April 1, 2025 17:47
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14202404975

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 80.928%
Totals Coverage Status
Change from base Build 14145452679: 1.9%
Covered Lines: 645
Relevant Lines: 797
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansueli mansueli mansueli requested changes

@grdsdev grdsdev grdsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olirice @coveralls @mansueli @grdsdev