Refactor authentication logic in fetch.ts #1415
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
fetch.ts
currently setsaccessToken
using a nullish coalescing (??
) fallback.This can lead to unintended behavior where
supabaseKey
is assigned ifgetAccessToken()
returns undefined or null.Before (Current behavior):
What is the new behavior?
The refactored code separates token retrieval from fallback logic.
Now, authentication headers are set only if
accessToken
exists.This improves clarity and avoids accidental assignment of
Authorization: Bearer undefined
.After (Refactored behavior):
Additional context
This change improves readability without altering core functionality.
No breaking changes expected.
Code remains compatible with the existing authentication flow.