Skip to content

fix: update gotrue version and modify client options class #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

leynier
Copy link
Contributor

@leynier leynier commented Dec 29, 2021

Now client options class does not make a deep copy in the replace method because local storage is an abstract class and not dict like before

Now client options class does not make a deep copy
in  the replace method because local storage is an
abstract class and not dict like before
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 29, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.55%.

Quality metrics Before After Change
Complexity 0.86 ⭐ 1.36 ⭐ 0.50 👎
Method Length 31.83 ⭐ 33.71 ⭐ 1.88 👎
Working memory 5.87 ⭐ 6.31 🙂 0.44 👎
Quality 83.70% 82.15% -1.55% 👎
Other metrics Before After Change
Lines 367 382 15
Changed files Quality Before Quality After Quality Change
supabase/client.py 85.02% ⭐ 85.78% ⭐ 0.76% 👍
supabase/lib/auth_client.py 83.52% ⭐ 69.42% 🙂 -14.10% 👎
supabase/lib/client_options.py 77.93% ⭐ 66.81% 🙂 -11.12% 👎
tests/test_client.py 82.51% ⭐ 82.10% ⭐ -0.41% 👎
tests/test_client_options.py 86.22% ⭐ 85.32% ⭐ -0.90% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
supabase/lib/client_options.py ClientOptions.replace 7 ⭐ 74 🙂 11 😞 63.95% 🙂 Extract out complex expressions
supabase/lib/auth_client.py SupabaseAuthClient.__init__ 0 ⭐ 45 ⭐ 15 😞 69.42% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@leynier leynier requested review from J0 and a team and removed request for J0 December 29, 2021 15:37
@dreinon
Copy link
Contributor

dreinon commented Jan 1, 2022

Are tests okay?

Copy link
Contributor

@anand2312 anand2312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J0 J0 merged commit 6fdd914 into supabase:jl--add-new-release Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants