Skip to content

ignore paths on ci #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2024
Merged

ignore paths on ci #737

merged 1 commit into from
Mar 23, 2024

Conversation

silentworks
Copy link
Contributor

@silentworks silentworks commented Mar 23, 2024

What kind of change does this PR introduce?

CI shouldn't run if there is a dependency update to the CI itself

What is the current behavior?

CI runs when there is a dependency update to the CI itself

What is the new behavior?

Additional context

@silentworks silentworks requested a review from a team as a code owner March 23, 2024 12:28
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @silentworks - I've reviewed your changes and they look great!

General suggestions:

  • Ensure that all relevant non-code paths are included in the paths-ignore list to maximize CI efficiency.
  • Consider periodically reviewing the paths-ignore list to adjust for project evolution and new non-code assets.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@silentworks silentworks merged commit 9ad4290 into main Mar 23, 2024
@silentworks silentworks deleted the chore/ignore-specific-paths-on-ci branch March 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant