Skip to content

feat: Added the no-unused-class-name rule using parser services #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Jun 19, 2023
Merged

feat: Added the no-unused-class-name rule using parser services #489

merged 37 commits into from
Jun 19, 2023

Conversation

marekdedic
Copy link
Contributor

Alternative proposal to #402, see sveltejs/svelte-eslint-parser#318 (comment)

marekdedic added 26 commits March 11, 2023 14:32
@marekdedic
test(no-unused-class-name): Added rule tests
660d537
@marekdedic
Merge branch 'main' into no-unused-class-name
7753853
@marekdedic
test(no-unused-class-name): added fixtures
3647bc1
@marekdedic
feat(no-unused-class-name): added the implementation of the rule
214ee0d
@marekdedic
feat(no-unused-class-name): added support for nested rules
f12bc23
@marekdedic
feat(no-unused-class-name): added proper lint issue message
64e5a9a
@marekdedic
docs(no-unused-class-name): added docs
c018c05
@marekdedic
test(no-unused-class-name): renamed fixture
d7053db
@marekdedic
feat(no-unused-class-name): added support for multiple classes on one…
ea8a7b5 
… element
@marekdedic
test(no-unused-class-name): added test for SASS support
cde0a7f
@marekdedic
test(no-unused-class-name): removed test for deprecated SASS syntax
57ba04b
@marekdedic
feat(no-unused-class-name): handling unavailable style AST
61e153e
@marekdedic
chore(no-unused-class-name): extracted findClassesInAttribute
09431e9
@marekdedic
test(no-unused-class-name): ignoring invalid style language test case…
efb0115 
… in eslint
@marekdedic
test(no-unused-class-name): added tests for various selectors
281c287
@marekdedic
chore(no-unused-class-name): switched from for cycle to flatMap
8c63f78
@marekdedic
chore(no-unused-class-name): removed unneeded type assertions
60e84ca
@marekdedic
feat(no-unused-class-name): added support for class directives
612a2dc
@marekdedic
chore(no-unused-class-name): using renamed SvelteStyle- node types
d6e7c62
@marekdedic
chore(no-unused-class-name): added a changeset
c1d0fa3
@marekdedic
chore(no-unused-class-name): update to reflect parser types
e627577
@marekdedic
chore(no-unused-class-name): using type narrowing on ESLintCompatible…
e0334b5 
…PostCSSNode
@marekdedic
Merge branch 'main' into no-unused-class-name
d3a5fd0
@marekdedic
chore(no-unused-class-name): removed yarn.lock
426ca67
@marekdedic
feat(no-ununsed-class-name): Using style AST from parser services
45a2835
@marekdedic
fix(no-ununsed-class-name): not reporting errors on invalid lang
0aeff3e
@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b7fb1b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marekdedic marekdedic marked this pull request as draft May 22, 2023 21:02
@marekdedic marekdedic marked this pull request as ready for review June 11, 2023 18:46
@marekdedic marekdedic mentioned this pull request Jun 11, 2023
Closed
ota-meshi
ota-meshi requested changes Jun 18, 2023
View reviewed changes
@marekdedic
Copy link
Contributor Author

There seems to be some error produced by prettier for tests/fixtures/rules/no-unused-class-name/valid/unknown-lang01-input.svelte, I haven't figured out how to get rid of it...

@marekdedic marekdedic requested a review from ota-meshi June 18, 2023 15:08
ota-meshi
ota-meshi approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for many improvements and implementation of this rule.

@ota-meshi ota-meshi merged commit cc321f4 into sveltejs:main Jun 19, 2023
@github-actions github-actions bot mentioned this pull request Jun 19, 2023
Merged
@marekdedic marekdedic deleted the no-unused-class-name-parser-services branch June 19, 2023 11:42
@marekdedic marekdedic mentioned this pull request Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marekdedic @ota-meshi