Skip to content

node build fails when using routes with umlauts #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noahsalvi opened this issue Sep 11, 2021 · 2 comments · Fixed by #2427
Closed

node build fails when using routes with umlauts #2403

noahsalvi opened this issue Sep 11, 2021 · 2 comments · Fixed by #2427
Milestone

Comments

@noahsalvi
Copy link

noahsalvi commented Sep 11, 2021

Describe the bug

Building the project with a node adapter fails. This bug was implemented in kit.163

Reproduction

  • Create sveltekit project with the kit version being 163 or newer
  • Install and configure adapter-node
  • Add route with umlaut character "ü.svelte".
  • npm run build

Logs

404 /ü
Error: 404 /ü
    at file:///Users/noahsalvi/Downloads/testa/node_modules/@sveltejs/kit/dist/chunks/index5.js:85:11
    at visit (file:///Users/noahsalvi/Downloads/testa/node_modules/@sveltejs/kit/dist/chunks/index5.js:212:5)
    at async prerender (file:///Users/noahsalvi/Downloads/testa/node_modules/@sveltejs/kit/dist/chunks/index5.js:290:6)
    at async Object.prerender (file:///Users/noahsalvi/Downloads/testa/node_modules/@sveltejs/kit/dist/chunks/index5.js:351:4)
    at async adapt (file:///Users/noahsalvi/Downloads/testa/node_modules/@sveltejs/adapter-node/index.js:104:4)
    at async adapt (file:///Users/noahsalvi/Downloads/testa/node_modules/@sveltejs/kit/dist/chunks/index5.js:376:2)
    at async file:///Users/noahsalvi/Downloads/testa/node_modules/@sveltejs/kit/dist/cli.js:1008:5
error Command failed with exit code 1.

System Info

System:
    OS: macOS 11.5.2
    CPU: (8) x64 Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz
    Memory: 70.39 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.4.0 - /usr/local/bin/node
    Yarn: 1.22.11 - /usr/local/bin/yarn
    npm: 7.18.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 93.0.4577.63
    Edge: 91.0.864.71
    Firefox: 91.0.2
    Safari: 14.1.2
  npmPackages:
    @sveltejs/adapter-node: ^1.0.0-next.46 => 1.0.0-next.46 
    @sveltejs/kit: 1.0.0-next.163 => 1.0.0-next.163 
    svelte: ^3.34.0 => 3.42.5

Severity

blocking an upgrade

Additional Information

No response

@benmccann
Copy link
Member

so sorry to keep breaking your app! I really think we're close to getting out all the wrinkles on this. thanks for your reports!

@noahsalvi
Copy link
Author

@benmccann no worries :)
SvelteKit is still in beta after all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants