[fix] encodeURI during prerender #2427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a3170fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Sep 14, 2021
sidharthv96
added a commit
to sidharthv96/kit
that referenced
this pull request
Sep 19, 2021
* 'master' of https://github.com/sveltejs/kit: (322 commits) Version Packages (next) (sveltejs#2438) [fix] revert sveltejs#2354 and fix double character decoding a different way (sveltejs#2435) chore: update dependencies (sveltejs#2447) [docs] add link to envPrefix option in env var FAQ (sveltejs#2445) Fix invalid changeset. Thanks GitHub bot :-p [feat] use the Vite server options in dev mode (sveltejs#2232) [fix] provide valid value for `letter-spacing` CSS property in template (sveltejs#2437) [docs] fix typo (sveltejs#2443) [fix] add svelte field when packaging (sveltejs#2431) Version Packages (next) (sveltejs#2428) [chore] update lockfile [fix] update to TS 4.4.3 (sveltejs#2432) [chore] add links to repository and homepage to package.json (sveltejs#2425) docs: use fragment for prefetching link (sveltejs#2429) [fix] encodeURI during prerender (sveltejs#2427) Version Packages (next) (sveltejs#2420) revert change to versioning during release workflow chore: update vite-plugin-svelte (sveltejs#2423) [chore] expose Body generic to hook functions (sveltejs#2413) [feat] adapter-node entryPoint option (sveltejs#2414) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2403
The browser sends an encoded URI. We should pass the same during prerender
I'll leave the test as a todo for now. Prerendering doesn't have tests yet, so we'll need to address that, but that's probably a bigger issue to address separately