-
-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: upgrade eslint to v9 #12268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade eslint to v9 #12268
Conversation
🦋 Changeset detectedLatest commit: f0dcf0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I have read the but it still feels weird to have an alpha dependency in the official template. Would |
Yeah, it is a bit weird. But it's much easier for users to just upgrade that one package than to do the whole migration from eslint v8 |
Migration GuideFor Prettier users, you can reference this diff.
- "@typescript-eslint/eslint-plugin": "^7.10.0",
- "@typescript-eslint/parser": "^7.10.0",
+ "typescript-eslint": "8.0.0-alpha.20", # JavaScript
pnpm i eslint@9 globals@latest -D
# TypeScript
pnpm i eslint@9 globals@latest typescript-eslint@rc-v8 -D
pnpm rm @typescript-eslint/eslint-plugin @typescript-eslint/parser
+ eslint.config.js
- .eslintrc.cjs
- .eslintignore # The ignore file should be removed! The content of the config files differs based on (TypeScript, Prettier) installation. Reference the |
I upgraded my ts app following these changes and now I'm seeing lots of errors around generics 7:29 error 'T' is not defined no-undef
8:18 error '$$Generic' is not defined no-undef
|
We tried before and had to rollback because
typescript-eslint
v7 was not compatible. Try again this time with a pre-release version, which seems to be quite stable. Otherwise we'd have to make all users wait another 2-4 monthsRef typescript-eslint/typescript-eslint#9141