Skip to content

fix(package): use provided tsconfig when calling emitDts #12612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

quentinderoubaix
Copy link
Contributor

@quentinderoubaix quentinderoubaix commented Aug 26, 2024

Handles second task of sveltejs/language-tools#2355


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: b08f930

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/package Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -1,6 +1,7 @@
{
"compilerOptions": {
"target": "ESNext",
"module": "ESNext"
"module": "ESNext",
"verbatimModuleSyntax": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: why was this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to remove a warning while running the unit tests, smth like "tsconfig verbatimModuleSyntax is required when using Svelte files with lang=ts"

This is not related to the original goal of the PR, it can be reverted

@benmccann benmccann added the pkg:svelte-package Issues related to svelte-package label Aug 26, 2024
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit c584dc2 into sveltejs:main Sep 6, 2024
10 of 12 checks passed
@quentinderoubaix quentinderoubaix deleted the pass-tsconfig-option-to-emitDts branch September 6, 2024 12:34
@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:svelte-package Issues related to svelte-package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants