-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(package): use provided tsconfig when calling emitDts #12612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package): use provided tsconfig when calling emitDts #12612
Conversation
🦋 Changeset detectedLatest commit: b08f930 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -1,6 +1,7 @@ | |||
{ | |||
"compilerOptions": { | |||
"target": "ESNext", | |||
"module": "ESNext" | |||
"module": "ESNext", | |||
"verbatimModuleSyntax": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious: why was this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to remove a warning while running the unit tests, smth like "tsconfig verbatimModuleSyntax is required when using Svelte files with lang=ts"
This is not related to the original goal of the PR, it can be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Handles second task of sveltejs/language-tools#2355
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits