Skip to content

chore: remove unnecessary try/catch #12762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
Merged

chore: remove unnecessary try/catch #12762

merged 1 commit into from
Oct 9, 2024

Conversation

benmccann
Copy link
Member

Vite should handle an error here, so we shouldn't need our own handling

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: a6548fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eltigerchino
Copy link
Member

eltigerchino commented Oct 7, 2024

Do you suppose these should fix these weird stackblitz errors?

stackblitz error

I'd approve but I don't have the information on whether Vite will handle the error here.

@benmccann
Copy link
Member Author

No, I doubt it will change that

If I get a chance later I can hardcode an error in this block locally to confirm that Vite handles it

@eltigerchino
Copy link
Member

eltigerchino commented Oct 9, 2024

I was curious and tested the hardcoded error you mentioned to try in the vite block itself. It seems it moves the error from just the browser to the browser and server (which seems better?). Other errors through Svelte files etc are unaffected. I'm in favour of this.

With try catch block:
error page

Without try catch block:
error page and error in console

@benmccann
Copy link
Member Author

awesome. thanks!

@benmccann benmccann merged commit a612292 into main Oct 9, 2024
13 checks passed
@benmccann benmccann deleted the try-catch branch October 9, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants