chore: convert preprocessor to vite plugin #13617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a056cf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
added
feature / enhancement
benmccann
force-pushed
the
enhancedimg-rm-preprocessor
branch
from
6674359 to
7605251
Compare
benmccann
force-pushed
the
enhancedimg-rm-preprocessor
branch
2 times, most recently
from
2c852b1 to
c306ecf
Compare
benmccann
force-pushed
the
enhancedimg-rm-preprocessor
branch
from
c306ecf to
9dfac09
Compare
benmccann
force-pushed
the
enhancedimg-rm-preprocessor
branch
from
9dfac09 to
a056cf7
Compare
Merged
|
Hi! Unfortunately this PR broke the compatibility with mdsvex: #13842 From what I understand, the "future-proof" fix would be to make mdsvex a Vite/Rollup plugin rather than a Svelte preprocessor, right? I may give it a try if time allows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes sveltejs/language-tools#2321
This is a breaking change as it adds a peer dependency on vite-plugin-svelte for resolving the Svelte config file
This changes the implementation from a preprocessor to a plugin with
enforce: 'pre'to help vite-plugin-svelte kill off it's preprocessing API. The code change looks pretty big as a result of the file rename, but it's not actually a huge changeI'm removing the warning from the docs about the plugin being unstable as I don't anticipate major API changes now that we've decided against renaming this to something like
<img data-enhanced />, etc.