Skip to content

[chore] Documentation on status and error in page store #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 26, 2022

Conversation

nhe23
Copy link
Contributor

@nhe23 nhe23 commented Jan 24, 2022

Fixes #3285 by improving the documentation on the page store. Also added note on usage with layout component

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2022

⚠️ No Changeset found

Latest commit: d6f4cd2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jan 24, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: d6f4cd2

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61ef38085556d40007ea1e33

@benmccann benmccann added the documentation Improvements or additions to documentation label Jan 25, 2022
@Rich-Harris Rich-Harris merged commit 5a6f290 into sveltejs:master Jan 26, 2022
@Rich-Harris
Copy link
Member

thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document page.error and page.status and ensure exposed to __layout
3 participants