Skip to content

[chore] remove TODO #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2022
Merged

[chore] remove TODO #3540

merged 1 commit into from
Jan 26, 2022

Conversation

benmccann
Copy link
Member

It looks like we're now using the browser fetch types instead of the node-fetch types so there's no longer a type checking warning. I'm not exactly sure how install-fetch doesn't run into an issue with the types being different or maybe it does and that's ignored elsewhere, but at least in this portion of the code there no longer seems to be an issue

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2022

⚠️ No Changeset found

Latest commit: 004dc83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 004dc83

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61f044eadacce40008852c1e

@Rich-Harris
Copy link
Member

node-fetch implements the fetch API, so the types match by design (there are some edge cases, e.g. it uses node streams instead of web streams to represent bodies, and Headers has a raw method, but for it's better to use standard types everywhere anyway)

@Rich-Harris Rich-Harris merged commit 39f556a into master Jan 26, 2022
@Rich-Harris Rich-Harris deleted the rm-todo branch January 26, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants