-
-
Notifications
You must be signed in to change notification settings - Fork 2k
update generated tsconfig #4791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2d3bd52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Maybe we should be using |
Good idea, have switched to that |
Thanks, this seems like the right fix to me |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0It's probably best to discuss the side effects of this change, it fixes my issue of #4460 and also #4764 - However this was changed in #4633 and maybe this change is what should stay and alternative solution to the issues can be done such as what I proposed here #4460 (comment)