-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[docs] be more specific about the definition of page endpoints #5198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think this is harder to understand than the current sentence and I'm not sure what it means. But I agree that the docs on page endpoints can be improved, especially with more info about how they are different from the load function. |
@kristjanmar how about now? |
Much better. "The filename for a page endpoint must also include any named layouts or matchers in its page's name." Maybe something like this would be optimal just to make it more clear that this is an IF: "If the page name has named layouts or matchers, then the filename for the page endpoint also needs to include them." |
Co-authored-by: Ben McCann <[email protected]>
Co-authored-by: Ben McCann <[email protected]>
much better 👍 |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0