You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that inputs was introduced in 1.3.0 and so all the inputs we declared were never being used. Also, they're completely optional. By default it will consider all non-gitignored files. So I've removed inputs as it's brittle and it seemed to we could just use the default
I also added a few more outputs that I think we may have been missing
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I don't have a lot to say about the Turbo config, but it looks like in the lockfile that we're on the same version of Turbo as we were before. The semver range has changed, but the lockfile has the same version in it as before, so there hasn't actually been an upgrade.
omitting inputs would result in tests being rerun even for docs changes. Iirc that was one of the main reasons to introduce turbo. Avoiding redundant executions.
omitting inputs would result in tests being rerun even for docs changes
Would it? Each package under packages would still be cached I believe, so I'm not sure there's anything that would really be rerun if something in documentation changes
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benmccann
changed the title
It turns out that
inputswas introduced in 1.3.0 and so all theinputswe declared were never being used. Also, they're completely optional. By default it will consider all non-gitignored files. So I've removedinputsas it's brittle and it seemed to we could just use the defaultI also added a few more
outputsthat I think we may have been missing