Skip to content

fix: Saving the root route will correctly update types #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github commented Aug 30, 2022

path.dirname was resolving to '.' for the root route, meaning it wouldn't match the '' identifier in the manifest. Easy fix.

Closes #6444.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2022

🦋 Changeset detected

Latest commit: b2aca7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@elliott-with-the-longest-name-on-github
Copy link
Contributor Author

@Rich-Harris

Hang on -- tests may pass, but I didn't add a test to verify this behavior (couldn't figure out how). Do we want to add a test? If no, I need to go manually check that the behavior is working as expected.

@elliott-with-the-longest-name-on-github
Copy link
Contributor Author

Can confirm on local repro that the changes we just made do work.

@Rich-Harris Rich-Harris merged commit b7f3e8b into master Aug 30, 2022
@Rich-Harris Rich-Harris deleted the 6444/sejohnson-fix-typegen branch August 30, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken auto generation of types
2 participants