-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: Saving the root route will correctly update types #6450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b2aca7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Rich Harris <[email protected]>
Co-authored-by: Rich Harris <[email protected]>
Hang on -- tests may pass, but I didn't add a test to verify this behavior (couldn't figure out how). Do we want to add a test? If no, I need to go manually check that the behavior is working as expected. |
Can confirm on local repro that the changes we just made do work. |
path.dirname
was resolving to '.' for the root route, meaning it wouldn't match the''
identifier in the manifest. Easy fix.Closes #6444.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0