Skip to content

[fix] tighten up navigation and invalidation logic #6924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 21, 2022
Merged

[fix] tighten up navigation and invalidation logic #6924

merged 8 commits into from
Sep 21, 2022

Conversation

dummdidumm
Copy link
Member

No tests yet because a) my brain is fried from thinking about all this b) want to make sure first these are the right fixes

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@dummdidumm
[fix] tighten up navigation and invalidation logic
f64a51b 
- Fixes #6844, invalidation is now only reset after navigation settled
- Fixes #5305, newer invalidations are no longer swalloed by ongoing older ones
- Fixes #6902, the pending prefetch is reset upon invalidation
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 2dbe1e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dummdidumm
dummdidumm commented Sep 20, 2022
View reviewed changes
Rich-Harris
Rich-Harris reviewed Sep 20, 2022
View reviewed changes
@Rich-Harris
Copy link
Member

This seems like the right direction, yeah

@dummdidumm dummdidumm force-pushed the navigation-and-invalidation-fixes branch from e465cbc to a98b6e7 Compare September 21, 2022 11:22
@dummdidumm dummdidumm mentioned this pull request Sep 21, 2022
Open
Rich-Harris
Rich-Harris reviewed Sep 21, 2022
View reviewed changes
Rich-Harris
Rich-Harris reviewed Sep 21, 2022
View reviewed changes
Rich-Harris
Rich-Harris approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion inline but LGTM 👍

@Rich-Harris Rich-Harris merged commit c60c9ff into master Sep 21, 2022
@Rich-Harris Rich-Harris deleted the navigation-and-invalidation-fixes branch September 21, 2022 16:45
@github-actions github-actions bot mentioned this pull request Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalidate doesn't work while prefetching Invalidate all + redirects not working as expected. Abort Stale Invalidation Request
2 participants
@dummdidumm @Rich-Harris