This repository was archived by the owner on Oct 13, 2022. It is now read-only.
Updates for 0.8 #40
Merged
Updates for 0.8 #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rich-Harris
commented
Mar 4, 2018
| @@ -37,8 +37,11 @@ self.addEventListener('fetch', event => { | |||
| // don't try to handle e.g. data: URIs | |||
| if (!url.protocol.startsWith('http')) return; | |||
|
|
|||
| // ignore dev server requests | |||
| if (url.hostname === self.location.hostname && url.port !== self.location.port) return; | |||
There was a problem hiding this comment.
at the moment the host for the dev client is always localhost:${someport} — it should probably be ${window.location.hostname}:${someport} so that debugging on mobile devices etc works
|
Seems the tests aren't running on Appveyor (they should have failed) |
This was referenced Mar 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General fixes and tweaks, some of which (e.g.
config.serviceworker) will depend on Sapper 0.8