Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

encodeURIComponent routes? #103

Closed
mrkishi opened this issue Jan 22, 2018 · 0 comments
Closed

encodeURIComponent routes? #103

mrkishi opened this issue Jan 22, 2018 · 0 comments

Comments

@mrkishi
Copy link
Member

mrkishi commented Jan 22, 2018

Special characters in filenames result in unreachable routes, since browsers will encode them before fetching.

Manually encoding the route names works: while /bézier-curves.html fails, /b%C3%A9zier-curves.html works fine for the /bézier-curves URL.

I think every browser correctly handles this type of conversion nowadays. Does anyone see an issue with Sapper automatically encoding routes?
Rich-Harris added a commit that referenced this issue Mar 4, 2018
@Rich-Harris
URI-encodes routes - fixes #103
854147f
Rich-Harris added a commit that referenced this issue Mar 5, 2018
@Rich-Harris
Merge branch 'master' into gh-103
b405e58
@Rich-Harris Rich-Harris mentioned this issue Mar 5, 2018
Merged
Rich-Harris added a commit that referenced this issue Mar 5, 2018
@Rich-Harris
Merge pull request #162 from sveltejs/gh-103
24bfcc8 
URI-encode routes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrkishi