Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Document --legacy #739

Closed
Rich-Harris opened this issue Aug 31, 2018 · 7 comments · Fixed by #1209
Closed

Document --legacy #739

Rich-Harris opened this issue Aug 31, 2018 · 7 comments · Fixed by #1209
Labels

Comments

@Rich-Harris
Copy link
Member

#280

@benallfree
Copy link

#280 (comment) I thought the same thing, maybe --include-legacy would be clearer.

@Conduitry Conduitry transferred this issue from sveltejs/sapper-legacy.svelte.dev Jun 11, 2019
@Conduitry Conduitry added the docs label Jun 11, 2019
@kylecordes
Copy link

Here is an alternative idea. Rather than document this option, consider removing the option. Instead a "production" build would automatically include differential bundling. In the future when there are almost no browsers left that need the old code, an option could be introduced to --skip-legacy.

Or maybe by then the ES5 output could be removed, and no option (thus no documentation other than "of course Sapper does differential bundling, you need not even ask") would ever be needed.

@swyxio
Copy link

swyxio commented Sep 9, 2019

@Conduitry - may i ask why this was transferred over from the docs repo?

i'm going to open up a WIP PR for this one and we can discuss documenting there

swyxio added a commit to swyxio/sapper.svelte.technology that referenced this issue Sep 9, 2019
document build options, as part of sveltejs/sapper#739
@Conduitry
Copy link
Member

This is the docs repo now as well. https://sapper.svelte.dev/ lives in the site directory of this repo. Since Sapper was updated for Svelte 3, the other repo is for what's at https://sapper-legacy.svelte.dev/.

@swyxio
Copy link

swyxio commented Sep 10, 2019

ok i've moved over the PR!

@diverent2
Copy link
Contributor

Here's another idea: How about using --support-legacy instead?
IMO this clarifies that it's meant for browser support without getting too verbose or causing confusion.

Just an idea though :)

@swyxio
Copy link

swyxio commented Nov 3, 2019

please open a new issue, i gave up on my pr

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants