Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Don't write service-worker.js to filesystem in dev mode #90

Closed
Rich-Harris opened this issue Jan 16, 2018 · 2 comments · Fixed by #97
Closed

Don't write service-worker.js to filesystem in dev mode #90

Rich-Harris opened this issue Jan 16, 2018 · 2 comments · Fixed by #97

Comments

@Rich-Harris
Copy link
Member

Added this in 0.5 so that sapper export could easily access the service-worker.js file, but it causes problems when deploying to Now because you don't have access to the filesystem.

Will revert that so I can redeploy svelte.technology, but this will mean that sapper export no longer includes the service worker. In other words I'm about to deliberately introduce a bug 🐛
@TehShrike
Copy link
Member

Now allows you to write to tmp, if that is viable?

@Rich-Harris
Copy link
Member Author

Could do, but it's not really necessary — I was only doing that because it was an easy way for sapper export to read the service worker. Just need to rejig things a bit so that we can grab it straight from memory

Rich-Harris added a commit that referenced this issue Jan 20, 2018
@Rich-Harris
return service worker from generate_asset_cache - fixes #90
75e7020
@Rich-Harris Rich-Harris mentioned this issue Jan 20, 2018
Merged
Rich-Harris added a commit that referenced this issue Jan 20, 2018
@Rich-Harris
Merge pull request #97 from sveltejs/gh-90
a305d3c 
return service worker from generate_asset_cache
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

return service worker from generate_asset_cache sveltejs/sapper
2 participants
@TehShrike @Rich-Harris