This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple slugs in route segment
Description
Currently you are not allowed to have multiple slugs in a single segment. (e.g.
src/routes/[file].[ext].js
)This merge request relates to issue #547.
The regex used to find these parts will detect
file].[ext
as a slug because it is greedy.I've made it non-greedy..
I also fixed an issue with non-dynamic parts of the segment (e.g. the
.
in the above filename) that are being treated as regex.Issues
Changes
.
=>\.
), these were fixed.Note
There is no lint script in your package.json.
Before submitting the PR, please make sure you do the following
npm run lint
!)Tests
npm test
oryarn test
)