Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Omit service-worker-index.html when service-worker.js does not exist #1291

Merged
merged 6 commits into from
Aug 17, 2020

Conversation

leaysgur
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

The service-worker-index.html should be generated only when we use ServiceWorker.

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me with just one minor comment

@leaysgur
Copy link
Contributor Author

@benmccann
Thank you for the review 😉
I deleted that comment.

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benmccann benmccann changed the title Omit service-worker-index.html when service-worker.js does noe exists. Omit service-worker-index.html when service-worker.js does not exists Jul 29, 2020
@benmccann benmccann changed the title Omit service-worker-index.html when service-worker.js does not exists Omit service-worker-index.html when service-worker.js does not exist Jul 29, 2020
@benmccann
Copy link
Member

@leader22 would you be able to rebase this PR?

@leaysgur
Copy link
Contributor Author

@benmccann I resolved conflicts but one test(unrelated to this PR) failed.

135 passing (1m)
1 failing

1) export-webpack
     "before all" hook: build app for "injects <link rel=preload> tags":
   Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/runner/work/sapper/sapper/test/apps/export-webpack/test.ts)

Can you re-run that action?

@benmccann benmccann merged commit 3f936ac into sveltejs:master Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants