This repository was archived by the owner on Jan 11, 2023. It is now read-only.
in exporting, handle binary files from server routes #1398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1103, resolves #1104. Builds on work in and supersedes #938 and #1105.
This is basically #1105, with conflicts with master resolved, code style adjusted, and with another case in
get_server_route_handler
of dangerous buffer-to-string conversion removed.This lets you follow
<img src>
,<source src>
, and<source srcset>
attributes when exporting, and to also correctly handle (without encoding corruption) when these are server routes that return binary files.