-
-
Notifications
You must be signed in to change notification settings - Fork 428
Handle dynamic css imports that are also statically imported #1494
Conversation
c98681b
to
93ef7c1
Compare
e6a1e46
to
4738857
Compare
Can we add a test for this as well? These were obviously weird edge cases that were never considered, and it would be nice to have some ability to guard against them going forward. |
Ok, I updated the tests so that they fail on |
Oh nice, I see that this also makes |
My reason for moving it was that it's only used in building the application by Rollup / the Sapper build process and so I was thinking it was a dev dependency. E.g. if someone runs |
No no, it's nice having it be bundled in instead. My understanding from the conversation here was that you were running into some issues when doing that, but it didn't seem very worthwhile to try to get to the bottom of it, because Sapper itself is only a dev dependency of apps that are written in it, and so built apps didn't have any additional dependencies. I'm a bit confused by parts of your last comment. I would expect that the only difference for someone installing |
I think we may have been talking about different things when you said "external" in #1452 (comment). I originally thought you meant was there a reason to make it a library and get it from npm instead of just putting the source code in Sapper. But now I understand you mean Feel free to ignore my last comment too 😄 I get a bit confused sometimes about Sapper being both a builder and a runtime in the same project Anyway, I don't think there's much difference whether this is in |
Fixes #1493. See the issue for a description of the change