This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Remove duped module definitions #1598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the types in #1402 by copying a file that the community had been using. I'm no TypeScript expert, but this looks fine and reasonable to me. @babichjacob I'll probably merge this unless you have any feedback on it |
benmccann
approved these changes
Oct 11, 2020
I'm also not a TypeScript expert, just a person who uses it 😄. |
|
Just FYI, press |
|
Hah, thanks 👍🏻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on windows, and I can't figure out how to take a screenshot of the auto-complete. However this is trivial to repro, create a new sapper project, run the TS migration then go to
servert.tsand try get auto-complete insapper.middleware({})- it will give nothing useful, if you cmd click in to middleware then delete these it will get fixedI don't know the history, of how it got setup here, but TS sees the first
declare moduleswhich effectively says 'make it an any` then later TS sees the more concrete types but they get eaten by the 'any' in the compiler (because all types are a subtype of any)