This repository was archived by the owner on Jan 11, 2023. It is now read-only.
leave anchor scrolling on initial load to browser #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be nice to backport this to 0.25 for the benefit of people on Svelte 2. Rollupjs.org springs to mind. edit: Although, the Rollup site is currently on 0.20 so I have no idea how much work that would be to get that up to date anyway. |
|
@Conduitry it would be amazing if this got backported. Sadly I'm stuck on v2 for the time being, and my stakeholders can't understand why something as "simple" as anchor links don't work! |
|
For the past couple days this change was locally made for deployments to svelte.dev and I haven't heard about any adverse effects. I think this should be good to go? |
|
I think that's the right call, yeah. Fingers crossed this deals with it once and for all |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331 hopefully without breaking anything else. This just sets noscroll to true during the initialization of the client-side app, so that wherever the browser decided to scroll to because of anchor fragments will be left untouched.
I don't really know what to test for this.