This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Hydrate on first load, not destroy #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Have added a test for this — it seems Svelte's hydration doesn't quite work as expected in slotted content, which we'll have to look into. |
|
Finally released in 0.6.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed the svelte-hackernews project and put a trace on this line and saw that
hydrateis false on the first load. Thecomponentvar in the runtime is still undefined, so!!componentevaluates tofalse. To hydrate on the first load, whencomponentisundefined, it should be!component.Can squash, if you merge.