This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Close event source before window is unloaded #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #981 Edit: here is how I fixed it: thgh@97f9bf0 but this PR is better |
|
Just wanted to confirm for any reviewers that I was experiencing this issue and had an identical fix. |
benmccann
approved these changes
May 30, 2020
thgh
approved these changes
Jun 1, 2020
|
FYI. The same is observed in Chrome when the connection is not explicitly closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Sapper is run in development mode, Firefox outputs a (meaningless) error in the console every time the page is reloaded manually or after a reload action was received by the dev client's
EventSource:This seems to be a bug in Firefox because the error doesn't occur in Chrome or Safari. I've added an event listener that closes the event source before the window is unloaded, which prevents the error.