-
-
Notifications
You must be signed in to change notification settings - Fork 24
fix: resolve to module scope for top level statements #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
import assert from "assert"; | ||
import { parseForESLint } from "../../../src"; | ||
import { getScopeFromNode } from "../../../src/scope"; | ||
|
||
describe('getScopeFromNode', () => { | ||
it('returns the global scope for the root node', () => { | ||
const { ast, scopeManager } = parseForESLint(''); | ||
|
||
assert.strictEqual(getScopeFromNode(scopeManager, ast), scopeManager.globalScope); | ||
}); | ||
|
||
it('returns the global scope for the script element', () => { | ||
const { ast, scopeManager } = parseForESLint('<script></script>'); | ||
const script = ast.body[0]; | ||
|
||
assert.strictEqual(getScopeFromNode(scopeManager, script), scopeManager.globalScope); | ||
}); | ||
|
||
it('returns the module scope for nodes for top level nodes of script', () => { | ||
const { ast, scopeManager } = parseForESLint('<script>import mod from "mod";</script>'); | ||
const importStatement = ast.body[0].body[0]; | ||
|
||
assert.strictEqual(getScopeFromNode(scopeManager, importStatement), scopeManager.globalScope.childScopes[0]); | ||
}); | ||
|
||
it('returns the module scope for nested nodes without their own scope', () => { | ||
const { ast, scopeManager } = parseForESLint('<script>a || b</script>'); | ||
const importStatement = ast.body[0].body[0].expression.right; | ||
|
||
assert.strictEqual(getScopeFromNode(scopeManager, importStatement), scopeManager.globalScope.childScopes[0]); | ||
}); | ||
|
||
it('returns the module scope for nested nodes for non-modules', () => { | ||
const { ast, scopeManager } = parseForESLint('<script>a || b</script>', { sourceType: 'script' }); | ||
const importStatement = ast.body[0].body[0].expression.right; | ||
|
||
assert.strictEqual(getScopeFromNode(scopeManager, importStatement), scopeManager.globalScope.childScopes[0]); | ||
}); | ||
|
||
it('returns the the child scope of top level nodes with their own scope', () => { | ||
const { ast, scopeManager } = parseForESLint('<script>function fn() {}</script>'); | ||
const fnNode = ast.body[0].body[0]; | ||
|
||
assert.strictEqual(getScopeFromNode(scopeManager, fnNode), scopeManager.globalScope.childScopes[0].childScopes[0]); | ||
}); | ||
|
||
it('returns the own scope for nested nodes', () => { | ||
const { ast, scopeManager } = parseForESLint('<script>a || (() => {})</script>'); | ||
const importStatement = ast.body[0].body[0].expression.right; | ||
|
||
assert.strictEqual(getScopeFromNode(scopeManager, importStatement), scopeManager.globalScope.childScopes[0].childScopes[0]); | ||
}); | ||
|
||
it('returns the the nearest child scope for statements inside non-global scopes', () => { | ||
const { ast, scopeManager } = parseForESLint('<script>function fn() { nested; }</script>'); | ||
const fnNode = ast.body[0].body[0]; | ||
const nestedStatement = fnNode.body.body[0]; | ||
|
||
assert.strictEqual(getScopeFromNode(scopeManager, nestedStatement), scopeManager.globalScope.childScopes[0].childScopes[0]); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR.
Can you replace the test with ESLint's
context.getScope
instead ofgetScopeFromNode
?getScopeFromNode
is not used in the actual rule implementation.