Skip to content

feat: Add warningFilter to SvelteConfig #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 31, 2024
+6 −0
Merged

feat: Add warningFilter to SvelteConfig #626

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa28650
add warningFilter
baseballyama Dec 31, 2024
1b117d4
changeset
baseballyama Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smart-rats-decide.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"svelte-eslint-parser": minor
---

feat: Add `warningFilter` to `SvelteConfig`
1 change: 1 addition & 0 deletions src/svelte-config/index.ts
View file
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@ export type SvelteConfig = {
warning: Compiler.Warning,
defaultHandler: (warning: Compiler.Warning) => void,
) => void;
warningFilter?: (warning: Compiler.Warning) => boolean;
[key: string]: unknown;
};

Unchanged files with check annotations Beta

View file
src/parser/converts/attr.ts
(key as any).parent = sAttr;
ctx.scriptLet.addObjectShorthandProperty(attribute.key, sAttr, (es) => {
if (
// FIXME: Older parsers may use the same node. In that case, do not replace.

Check warning on line 173 in src/parser/converts/attr.ts

GitHub Actions / lint 

Unexpected 'fixme' comment: 'FIXME: Older parsers may use the same...'
// We will drop support for ESLint v7 in the next major version and remove this branch.
es.key !== es.value
) {
View file
src/parser/template.ts
import type {} from "svelte"; // FIXME: Workaround to get type information for "svelte/compiler"

Check warning on line 1 in src/parser/template.ts

GitHub Actions / lint 

Unexpected 'fixme' comment: 'FIXME: Workaround to get type...'
import { parse } from "svelte/compiler";
import type * as Compiler from "./svelte-ast-types-for-v5.js";
import type * as SvAST from "./svelte-ast-types.js";