Skip to content

chore: drop require in benchmark #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2025
Merged

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Mar 29, 2025

In latest node, tsx/node seem to load this benchmark file as ESM which results in an error when trying to use require.resolve.

We can achieve the same with regular path resolution, using import.meta to get hold of the current path.

In latest node, tsx/node seem to load this benchmark file as ESM which
results in an error when trying to use `require.resolve`.

We can achieve the same with regular path resolution, using
`import.meta` to get hold of the current path.
Copy link

changeset-bot bot commented Mar 29, 2025

⚠️ No Changeset found

Latest commit: 3b092d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 29, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/svelte-eslint-parser@695

Published Instant Preview Packages:

View Commit

@coveralls
Copy link

coveralls commented Mar 29, 2025

Pull Request Test Coverage Report for Build 14147614502

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 94.661%

Totals Coverage Status
Change from base Build 14097215751: 0.002%
Covered Lines: 10478
Relevant Lines: 10945

💛 - Coveralls

@baseballyama baseballyama merged commit 157d486 into sveltejs:main Mar 29, 2025
12 checks passed
@43081j 43081j deleted the fix-bench branch March 29, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants