-
-
Notifications
You must be signed in to change notification settings - Fork 24
chore: drop require in benchmark #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In latest node, tsx/node seem to load this benchmark file as ESM which results in an error when trying to use `require.resolve`. We can achieve the same with regular path resolution, using `import.meta` to get hold of the current path.
|
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your Local
Published Instant Preview Packages:
|
Pull Request Test Coverage Report for Build 14147614502Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
In latest node, tsx/node seem to load this benchmark file as ESM which results in an error when trying to use
require.resolve
.We can achieve the same with regular path resolution, using
import.meta
to get hold of the current path.