perf(typescript): strip projectService from parser options when needed
#704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f6afc77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mcous
force-pushed
the
perf/typescript-strip-project-service
branch
from
f00e609 to
7f4d62e
Compare
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
Pull Request Test Coverage Report for Build 14543931958Details
💛 - Coveralls |
Comment on lines
+118
to
+129
| export function withoutProjectParserOptions( | ||
| options: NormalizedParserOptions, | ||
| ): NormalizedParserOptions { | ||
| const { | ||
| project: _strippedProject, | ||
| projectService: _strippedProjectService, | ||
| EXPERIMENTAL_useProjectService: _strippedExperimentalUseProjectService, | ||
| ...result | ||
| } = options; | ||
|
|
||
| return result; | ||
| } |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to sveltejs/eslint-plugin-svelte#1084, but does not resolve it. During performance testing, I found a large discrepancy in lint times between
project: './tsconfig.json'andprojectService: true. Usingprojectwas slow, but usingprojectServicewas extremely slow.While comparing the Svelte parser with the similar Vue parser, I noticed that when the Svelte parser tries to use the TS parser without type information, it strips the
projectparser option. However, the Vue parser strips bothprojectandprojectService.This PR ensures all typing-related parser options are stripped when needed rather than only
project. This brings lint times usingprojectServiceinto alignment withproject- still slow, but less slow