Skip to content

(fix) return default settings when no tsconfig found #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

dummdidumm
Copy link
Member

This prevents the code from being transpiled as es3 in this situation, which makes the const $$$$$ = .. separator get transformed into var $$$$$ = ... which then is no longer split out. This situation came up in the tests of svelte-jester.
No test added, because it's not really possible, because there's a tsconfig in this repo which would be found.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test

@kaisermann kaisermann merged commit 6443b45 into sveltejs:main Sep 20, 2021
kaisermann pushed a commit that referenced this pull request Sep 20, 2021
@kaisermann
Copy link
Member

Thanks 🎉 Released in v4.9.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants