Skip to content

fix: deprecate type attribute #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2021
Merged

fix: deprecate type attribute #417

merged 3 commits into from
Oct 2, 2021

Conversation

kaisermann
Copy link
Member

@kaisermann kaisermann commented Sep 30, 2021 •
edited
Loading

FIxes #414

  • Deprecate lang="typescript"
  • Deprecate type="text/ts"
  • Deprecate type="text/typescript"

I think the language detection and the auto preprocessor are still in the need of a significant refactor, but this should be enough for now.

@kaisermann kaisermann mentioned this pull request Sep 30, 2021
Closed
@kaisermann kaisermann force-pushed the deprecate-type-lang-attr branch from fccc450 to 8c8a795 Compare September 30, 2021 14:47
@kaisermann kaisermann marked this pull request as ready for review September 30, 2021 14:48
dummdidumm
dummdidumm reviewed Sep 30, 2021
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a global to src/modules/language.ts that checks if the warning was already thrown, to only throw it once per npm process to prevent pollution of logs. Other than this this looks good to me, thank you very much 👍

@kaisermann kaisermann merged commit 2632a88 into main Oct 2, 2021
@kaisermann kaisermann deleted the deprecate-type-lang-attr branch October 2, 2021 11:08
@kaisermann
Copy link
Member Author

Released in v4.9.8 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate type=".." and several lang=".."
2 participants
@kaisermann @dummdidumm