Also check for null-valued attributes

kaisermann · kaisermann · commit 89c1fa675bc4 · 2018-08-20T23:02:58.000-03:00
diff --git a/src/shared/dom.js b/src/shared/dom.js
@@ -82,7 +82,7 @@ export function removeListener(node, event, handler) {
 }
 
 export function setAttribute(node, attribute, value) {
-	if (value === undefined) removeAttribute(node, attribute);
+	if (value == null) removeAttribute(node, attribute);
 	else node.setAttribute(attribute, value);
 }
 
diff --git a/test/js/samples/dont-use-dataset-in-legacy/expected-bundle.js b/test/js/samples/dont-use-dataset-in-legacy/expected-bundle.js
@@ -22,7 +22,12 @@ function createText(data) {
 }
 
 function setAttribute(node, attribute, value) {
-	node.setAttribute(attribute, value);
+	if (value == null) removeAttribute(node, attribute);
+	else node.setAttribute(attribute, value);
+}
+
+function removeAttribute(node, attribute) {
+	node.removeAttribute(attribute);
 }
 
 function blankObject() {
diff --git a/test/js/samples/dont-use-dataset-in-svg/expected-bundle.js b/test/js/samples/dont-use-dataset-in-svg/expected-bundle.js
@@ -22,7 +22,12 @@ function createSvgElement(name) {
 }
 
 function setAttribute(node, attribute, value) {
-	node.setAttribute(attribute, value);
+	if (value == null) removeAttribute(node, attribute);
+	else node.setAttribute(attribute, value);
+}
+
+function removeAttribute(node, attribute) {
+	node.removeAttribute(attribute);
 }
 
 function blankObject() {
diff --git a/test/js/samples/input-files/expected-bundle.js b/test/js/samples/input-files/expected-bundle.js
@@ -26,7 +26,12 @@ function removeListener(node, event, handler) {
 }
 
 function setAttribute(node, attribute, value) {
-	node.setAttribute(attribute, value);
+	if (value == null) removeAttribute(node, attribute);
+	else node.setAttribute(attribute, value);
+}
+
+function removeAttribute(node, attribute) {
+	node.removeAttribute(attribute);
 }
 
 function blankObject() {
diff --git a/test/js/samples/input-range/expected-bundle.js b/test/js/samples/input-range/expected-bundle.js
@@ -26,7 +26,12 @@ function removeListener(node, event, handler) {
 }
 
 function setAttribute(node, attribute, value) {
-	node.setAttribute(attribute, value);
+	if (value == null) removeAttribute(node, attribute);
+	else node.setAttribute(attribute, value);
+}
+
+function removeAttribute(node, attribute) {
+	node.removeAttribute(attribute);
 }
 
 function toNumber(value) {
diff --git a/test/js/samples/input-without-blowback-guard/expected-bundle.js b/test/js/samples/input-without-blowback-guard/expected-bundle.js
@@ -26,7 +26,12 @@ function removeListener(node, event, handler) {
 }
 
 function setAttribute(node, attribute, value) {
-	node.setAttribute(attribute, value);
+	if (value == null) removeAttribute(node, attribute);
+	else node.setAttribute(attribute, value);
+}
+
+function removeAttribute(node, attribute) {
+	node.removeAttribute(attribute);
 }
 
 function blankObject() {

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ export function removeListener(node, event, handler) {`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`export function setAttribute(node, attribute, value) {`
`85`		`- if (value === undefined) removeAttribute(node, attribute);`
	`85`	`+ if (value == null) removeAttribute(node, attribute);`
`86`	`86`	`else node.setAttribute(attribute, value);`
`87`	`87`	`}`
`88`	`88`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,12 @@ function createText(data) {`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`function setAttribute(node, attribute, value) {`
`25`		`- node.setAttribute(attribute, value);`
	`25`	`+ if (value == null) removeAttribute(node, attribute);`
	`26`	`+ else node.setAttribute(attribute, value);`
	`27`	`+}`
	`28`	`+`
	`29`	`+function removeAttribute(node, attribute) {`
	`30`	`+ node.removeAttribute(attribute);`
`26`	`31`	`}`
`27`	`32`
`28`	`33`	`function blankObject() {`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,12 @@ function createSvgElement(name) {`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`function setAttribute(node, attribute, value) {`
`25`		`- node.setAttribute(attribute, value);`
	`25`	`+ if (value == null) removeAttribute(node, attribute);`
	`26`	`+ else node.setAttribute(attribute, value);`
	`27`	`+}`
	`28`	`+`
	`29`	`+function removeAttribute(node, attribute) {`
	`30`	`+ node.removeAttribute(attribute);`
`26`	`31`	`}`
`27`	`32`
`28`	`33`	`function blankObject() {`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,12 @@ function removeListener(node, event, handler) {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`function setAttribute(node, attribute, value) {`
`29`		`- node.setAttribute(attribute, value);`
	`29`	`+ if (value == null) removeAttribute(node, attribute);`
	`30`	`+ else node.setAttribute(attribute, value);`
	`31`	`+}`
	`32`	`+`
	`33`	`+function removeAttribute(node, attribute) {`
	`34`	`+ node.removeAttribute(attribute);`
`30`	`35`	`}`
`31`	`36`
`32`	`37`	`function blankObject() {`