-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svelte5: Snippet
now causes type issues if being passed as prop
#13670
Comments
I cant seem to reproduce this error, have you checked that you're running the latest versions of the dependencies. |
Yes, it is happening on [email protected] for me. I'm not sure if I guess this is the way it should be done and the docs is a bit outdated? |
Also cannot reproduce this. The main thing that needs to be up do date is your Svelte extension which runs the language server, transforms and checks the code. |
Svelte extension is latest and I also tried downgrading to old versions from weeks ago, it still showing the error. I'm kinda confused what is happening but this seems like a problem on my end after all this. I'll try re-installing node modules and whatever I can. Thanks for the confirmation! |
You can also try running |
:-) what should I say. I am also getting this error. |
I spent a ton of time tracking this down. The general version of this is caused by the use of unique symbol as the snippet return type - it is getting confused between instances of the Snippet<[]> type depending on where the import exactly comes from, because every instance of the unique symbol is a different one. The typeof on the SnippetReturn makes sure that for any imports from the exact same place, you will get the same unique symbol reference. But, unfortunately, if they come from different places, this will fail. As a concrete example of this, the Snippet type in This is the cause of most of these errors, AFAICT. I will open a new bug report with more details. |
Potential bug in svelte itself, see: - sveltejs/svelte#13670 - sveltejs/svelte#15182
Potential bug in svelte itself, see: - sveltejs/svelte#13670 - sveltejs/svelte#15182
Describe the bug
Passing a snippet to a parameter of type
Snippet
will now cause type issues but renders just fine in runtime.Reproduction
https://svelte-5-preview.vercel.app/#H4sIAAAAAAAACsVTTYvbMBD9K69qqROwHejRcUxL6a2Hsru31RaceJwIZEnVR9Jg_N-LZacJXQg9tTpJozdfb-b1rBWSHCuee6bqjljBPhnDUubPZny4I0lPLGVOB7sbLaXbWWF8xRX3ojPaenzWndGKlP-A1uoOSb66mvIpRLLmqlxdfVX_1ilhDHkcSEq9WA5clc7UqjppK5tyFe9c9asZN4xe5U2u2b7pY4ABqwrlmyyDaHHWASZ4-INwePjy7SuEwtHtdEM4CX_A0yNkrfah3hMc2SNZkKq3kpoU_kB2hEmJLWEkAsK5QA7xI8sqrmKi-XyfDldPIzRZLLGp8EA-2GgpJ5YWfCaTs2X-OJVeJRAOSnvUzol9LABeTzmTGVQ-v1RJzhUwxe-R9B8tqYYs8jwf0AXnx0p3tZTUTP3VmL2TApzNc4ph-8sPhnla84A4W2PA-4jS7QU19XG3zv9SUI6nk0Yj2pYsqSmUm1LFoY_LDPopnE-xjZtAZ9SWEJQlWXtqIqX_itSgxI9AcOduq-VdNv9AZlnFUtbpRrSCGlZ4G2hIf4v1Koe_0Gxc-Q1n3nF2q9_7LaxH5E4r59FfNIehuD6KG88N3hmrjVssX-n9Qu_stVgOrxt7GX4B-7tuupEEAAA=
Logs
No response
System Info
Severity
annoyance
The text was updated successfully, but these errors were encountered: