-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: spreading style is not consistent with attribute #15323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
23ac6b5
style must be set via set_attribute
adiguba 8d40eda
test
adiguba e174c0d
changeset
adiguba e52b534
add empty string and null in test
adiguba 6d40878
explanatory comment
Rich-Harris 174629d
this is now redundant, set_attribute takes care of it
Rich-Harris ece16ad
drive-by
Rich-Harris c3934d6
tweak changeset
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'svelte': patch | ||
--- | ||
|
||
fix: always use `setAttribute` when setting `style` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
packages/svelte/tests/runtime-runes/samples/style-update/_config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
import { flushSync } from 'svelte'; | ||
import { test } from '../../test'; | ||
|
||
const style_1 = 'invalid-key:0; margin:4px;;color: green ;color:blue '; | ||
const style_2 = ' other-key : 0 ; padding:2px; COLOR:green; color: blue'; | ||
|
||
// https://github.com/sveltejs/svelte/issues/15309 | ||
export default test({ | ||
props: { | ||
style: style_1 | ||
}, | ||
|
||
html: ` | ||
<div style="${style_1}"></div> | ||
<div style="${style_1}"></div> | ||
|
||
<custom-element style="${style_1}"></custom-element> | ||
<custom-element style="${style_1}"></custom-element> | ||
`, | ||
|
||
async test({ assert, target, component }) { | ||
component.style = style_2; | ||
flushSync(); | ||
|
||
assert.htmlEqual( | ||
target.innerHTML, | ||
` | ||
<div style="${style_2}"></div> | ||
<div style="${style_2}"></div> | ||
|
||
<custom-element style="${style_2}"></custom-element> | ||
<custom-element style="${style_2}"></custom-element> | ||
` | ||
); | ||
|
||
component.style = ''; | ||
flushSync(); | ||
|
||
assert.htmlEqual( | ||
target.innerHTML, | ||
` | ||
<div style=""></div> | ||
<div style=""></div> | ||
|
||
<custom-element style=""></custom-element> | ||
<custom-element style=""></custom-element> | ||
` | ||
); | ||
|
||
component.style = null; | ||
flushSync(); | ||
|
||
assert.htmlEqual( | ||
target.innerHTML, | ||
` | ||
<div></div> | ||
<div></div> | ||
|
||
<custom-element></custom-element> | ||
<custom-element></custom-element> | ||
` | ||
); | ||
} | ||
}); |
9 changes: 9 additions & 0 deletions
9
packages/svelte/tests/runtime-runes/samples/style-update/main.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<script> | ||
let { style } = $props(); | ||
</script> | ||
|
||
<div {style}></div> | ||
<div {...{style}}></div> | ||
|
||
<custom-element {style}></custom-element> | ||
<custom-element {...{style}}></custom-element> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that is necessary, was it reall inconsistent before? Also see my question in the related issue