Skip to content

fix: null and warnings for local handlers #15460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2025
Merged

Conversation

adiguba
Copy link
Contributor

@adiguba adiguba commented Mar 6, 2025

Fix some problems with event-handlers declared as local variables :

  • Delegated events ignore the null value.
  • The event_handler_invalid is not printed for invalid handlers.

And some little fix for all event-handlers :

  • The event_handler_invalid will print the correct name for capture event (ex: onclickcapture instead of onclick).
  • The event_handler_invalid warning will not hide the TypeError "xxx is not a function"
  • Do no use "hoisted function" when the function do no have hoisted_params.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: 2671dc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15460

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice — made one small tweak, to prevent the deopt in the case of things like

let onclick = () => {...};

which are essentially equivalent to function declarations, taking advantage of #15359. There may be other places where we can take advantage of is_function

@Rich-Harris Rich-Harris merged commit c5912aa into sveltejs:main Mar 7, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message when using a non-function as an event handler
2 participants