Skip to content

Fix: consider component and its snippets during css pruning #15630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025

Conversation

7nik
Copy link
Contributor

@7nik 7nik commented Mar 28, 2025

Fixes #15523

This PR add matching a component against :global(...) in the siblings combinators.
Also, it adds considering the component's content and snippets/slots as potentially located at the root during seeking for sibling elements.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@svelte-docs-bot
Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15630

dummdidumm
dummdidumm previously approved these changes Mar 28, 2025
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good mostly, but the tests need fixing

@dummdidumm dummdidumm dismissed their stale review March 28, 2025 15:51

tests need fixing

Copy link

changeset-bot bot commented Mar 28, 2025

🦋 Changeset detected

Latest commit: 5814948

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit e035e28 into sveltejs:main Mar 31, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive "Unused CSS selector" on ":global() + .class"
3 participants