Skip to content

docs: add inline documentation for svelte/reactivity #15722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 17, 2025
Merged

docs: add inline documentation for svelte/reactivity #15722

merged 8 commits into from
Apr 17, 2025

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Apr 10, 2025 •
edited
Loading

Alternative to #14799. Rather than adding stuff to the preamble, we should just properly document the classes themselves

  • SvelteDate
  • SvelteMap
  • SvelteSet
  • SvelteURL
  • SvelteURLSearchParams

@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-svelte-15722-svelte.vercel.app/

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15722

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a52c869

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris marked this pull request as ready for review April 10, 2025 19:28
@Rich-Harris Rich-Harris mentioned this pull request Apr 10, 2025
Closed
6 tasks
bytecodemanipulator
bytecodemanipulator reviewed Apr 13, 2025
View reviewed changes
@Rich-Harris @bytecodemanipulator
Apply suggestions from code review
a52c869 
Co-authored-by: bytecodemanipulator <[email protected]>
@Rich-Harris Rich-Harris merged commit 262b281 into main Apr 17, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the svelte-reactivity-docs branch April 17, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bytecodemanipulator bytecodemanipulator bytecodemanipulator left review comments

@paoloricciuti paoloricciuti paoloricciuti approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rich-Harris @paoloricciuti @bytecodemanipulator