fix: put expressions in effects unless known to be static #15792
+33
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that a template expression/attribute is wrapped in an effect unless we can guarantee that it won't update. It means that we don't lose reactivity in edge cases like this:
Draft because
scope.evaluate(...)
can't currently handle cyclical bindings (which is already a bug, this PR just exposes it), but I don't want to fix that until #15781 is merged since conflicts are likely.Closes #15289 (as well as many previous issues that were closed as 'not planned', but probably shouldn't have been), closes #15292
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint