Skip to content

fix: put expressions in effects unless known to be static #15792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Apr 18, 2025

This ensures that a template expression/attribute is wrapped in an effect unless we can guarantee that it won't update. It means that we don't lose reactivity in edge cases like this:

<script>
  let count = $state(0);

  let object = {
    toString() {
      return count;
    }
  };
</script>

<button onclick={() => count += 1}>
  {object}
</button>

Draft because scope.evaluate(...) can't currently handle cyclical bindings (which is already a bug, this PR just exposes it), but I don't want to fix that until #15781 is merged since conflicts are likely.

Closes #15289 (as well as many previous issues that were closed as 'not planned', but probably shouldn't have been), closes #15292

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 18, 2025

🦋 Changeset detected

Latest commit: 14642b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15792

@Ocean-OS Ocean-OS mentioned this pull request Apr 18, 2025
9 tasks
@Ocean-OS
Copy link
Contributor

What does cyclical bindings mean in this context?

@Rich-Harris
Copy link
Member Author

{#if true}
{@const a = b}
{@const b = a}
<h1>hello {a}</h1>
{/if}

@Ocean-OS
Copy link
Contributor

Wouldn't that just be an error, since b is referenced before being declared?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic class string coercion is not reactive
2 participants