Skip to content

fix: update onMount type definition to prevent async function return #8136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 18, 2023
Merged

fix: update onMount type definition to prevent async function return #8136

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7ea02c8
update onmount typing to prevent async function return
chrskerr Dec 22, 2022
5522a35
Merge remote-tracking branch 'upstream/master' into onMount-type-prev…
baseballyama Feb 23, 2023
eb97b53
enhance type
baseballyama Feb 23, 2023
1dec6e4
simplify
baseballyama Feb 23, 2023
f7c2a66
force conflict so I can merge version-4 into this
dummdidumm Apr 14, 2023
c941525
Merge branch 'version-4' into onMount-type-prevent-async-function-return
dummdidumm Apr 14, 2023
cda63cf
docs, test
dummdidumm Apr 14, 2023
5c15082
lint
dummdidumm Apr 14, 2023
1246260
Update src/runtime/internal/lifecycle.ts
dummdidumm Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime/internal/lifecycle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export function beforeUpdate(fn: () => any) {
*
* https://svelte.dev/docs#run-time-svelte-onmount
*/
export function onMount(fn: () => any) {
export function onMount<T>(fn: (() => T extends Promise<void> ? T : T extends Promise<unknown> ? never : T)): void {
get_current_component().$$.on_mount.push(fn);
}

Expand Down