Skip to content

[Libs/JS] Revert ESM package update #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2024
Merged

[Libs/JS] Revert ESM package update #1556

merged 1 commit into from
Dec 10, 2024

Conversation

svix-lucho
Copy link
Contributor

Revert the ESM package update. I'm still investigating some issues with importing the ESM version, but in the meanwhile, let's revert to the previous working state.

@svix-lucho svix-lucho marked this pull request as ready for review December 9, 2024 20:43
@svix-lucho svix-lucho requested a review from a team as a code owner December 9, 2024 20:43
@svix-lucho svix-lucho merged commit 6ec657d into main Dec 10, 2024
2 checks passed
@svix-lucho svix-lucho deleted the lucho/esm-fix-revert branch December 10, 2024 19:51
@svix-jplatte svix-jplatte mentioned this pull request Dec 12, 2024
Merged
svix-jplatte added a commit that referenced this pull request Dec 12, 2024
@svix-jplatte
Version 1.44.0 (#1565)
67b5237 
## What's changed

* Libs/JavaScript: Revert packaging-related change because it broke for
some users ([#1556])
* Libs/Rust: Remove unused optional `PostOptions` parameters from
non-POST methods ([#1557])

[#1556]: #1556
[#1557]: #1557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svix-james svix-james svix-james approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svix-lucho @svix-james