js: Add generated query parameter types #1571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And get rid of internal ListOptions type.
svix-jplatte
force-pushed
the
jplatte/js-gen
branch
from
6d84e6a to
36e30f3
Compare
svix-lucho
approved these changes
Dec 17, 2024
svix-lucho
reviewed
Dec 17, 2024
svix-jplatte
added a commit
that referenced
this pull request
Dec 18, 2024
Following what I just did for JS (#1571). Part of svix/monorepo-private#9576.
svix-jplatte
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And get rid of internal ListOptions type.
The ones without docs are not getting generated yet for various reasons, but I think this is a good enough start for replacing the high-level JS API with generated code.
Part of https://github.com/svix/monorepo-private/issues/9576.