-
Notifications
You must be signed in to change notification settings - Fork 6k
adding support for java dates #2077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@spotby thanks for the PR. If I understand it correctly, the change is backward compatible. I'll merge this later as we already have a few Swift PRs in the queue. |
Hey guys, there is a small problem with this PR, but I'm new to all of this and don't know how to update it. I pushed the fix to my swift-java-date branch that I created the PR from. Do I have to re submit? |
Hi @spotby you should be able to update your branch and the PR will update itself. |
nope, its good to go. This should be a non breaking change. thanks guys!
|
@spotby thanks again. Next time please update the Swift Petstore sample as mentioned in https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md |
FYI. All test cases passed after updating the Swift petstore sample:
|
Hey guys,
I was having some trouble with generating an API for my jersey based java project (dropbox). All of my dates generated for my responses were in java date format. I added support for this format as a fallback when parsing dates. if you like it, take it :)