Skip to content

adding support for java dates #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2016
Merged

Conversation

spotby
Copy link

@spotby spotby commented Feb 9, 2016

Hey guys,

I was having some trouble with generating an API for my jersey based java project (dropbox). All of my dates generated for my responses were in java date format. I added support for this format as a fallback when parsing dates. if you like it, take it :)

@wing328 wing328 added this to the v2.1.6 milestone Feb 9, 2016
@wing328
Copy link
Contributor

wing328 commented Feb 9, 2016

@spotby thanks for the PR. If I understand it correctly, the change is backward compatible.

I'll merge this later as we already have a few Swift PRs in the queue.

@spotby
Copy link
Author

spotby commented Feb 9, 2016

Hey guys, there is a small problem with this PR, but I'm new to all of this and don't know how to update it. I pushed the fix to my swift-java-date branch that I created the PR from. Do I have to re submit?

@fehguy
Copy link
Contributor

fehguy commented Feb 9, 2016

Hi @spotby you should be able to update your branch and the PR will update itself.

@wing328
Copy link
Contributor

wing328 commented Feb 10, 2016

@spotby I saw your change to change sourceSpring to source. Is there anything else you would like to change?

@spotby
Copy link
Author

spotby commented Feb 10, 2016

nope, its good to go. This should be a non breaking change. thanks guys!

On Feb 10, 2016, at 4:40 AM, wing328 [email protected] wrote:

@spotby https://github.com/spotby I saw your change spotby@cdc9fb5 to change sourceSpring to source. Is there anything else you would like to change?


Reply to this email directly or view it on GitHub #2077 (comment).

@wing328
Copy link
Contributor

wing328 commented Feb 11, 2016

@spotby thanks again. Next time please update the Swift Petstore sample as mentioned in https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md

wing328 added a commit that referenced this pull request Feb 11, 2016
@wing328 wing328 merged commit f50174e into swagger-api:master Feb 11, 2016
@wing328
Copy link
Contributor

wing328 commented Feb 11, 2016

FYI. All test cases passed after updating the Swift petstore sample:

** TEST SUCCEEDED **

09:09:09.842 SwaggerClient[19930:715927] _XCT_testBundleReadyWithProtocolVersion:minimumVersion: reply received
09:09:09.848 SwaggerClient[19930:715927] _IDE_startExecutingTestPlanWithProtocolVersion:16
Test Suite 'All tests' started at 2016-02-11 09:09:09.877
Test Suite 'SwaggerClientTests.xctest' started at 2016-02-11 09:09:09.878
Test Suite 'PetAPITests' started at 2016-02-11 09:09:09.878
Test Case '-[SwaggerClientTests.PetAPITests test1CreatePet]' started.
Test Case '-[SwaggerClientTests.PetAPITests test1CreatePet]' passed (0.930 seconds).
Test Case '-[SwaggerClientTests.PetAPITests test2GetPet]' started.
Test Case '-[SwaggerClientTests.PetAPITests test2GetPet]' passed (0.596 seconds).
Test Case '-[SwaggerClientTests.PetAPITests test3DeletePet]' started.
Test Case '-[SwaggerClientTests.PetAPITests test3DeletePet]' passed (0.442 seconds).
Test Suite 'PetAPITests' passed at 2016-02-11 09:09:11.847.
     Executed 3 tests, with 0 failures (0 unexpected) in 1.967 (1.970) seconds
Test Suite 'StoreAPITests' started at 2016-02-11 09:09:11.848
Test Case '-[SwaggerClientTests.StoreAPITests test1PlaceOrder]' started.
Test Case '-[SwaggerClientTests.StoreAPITests test1PlaceOrder]' passed (0.577 seconds).
Test Case '-[SwaggerClientTests.StoreAPITests test2GetOrder]' started.
Test Case '-[SwaggerClientTests.StoreAPITests test2GetOrder]' passed (0.510 seconds).
Test Case '-[SwaggerClientTests.StoreAPITests test3DeleteOrder]' started.
Test Case '-[SwaggerClientTests.StoreAPITests test3DeleteOrder]' passed (0.613 seconds).
Test Suite 'StoreAPITests' passed at 2016-02-11 09:09:13.551.
     Executed 3 tests, with 0 failures (0 unexpected) in 1.701 (1.703) seconds
Test Suite 'UserAPITests' started at 2016-02-11 09:09:13.552
Test Case '-[SwaggerClientTests.UserAPITests test1CreateUser]' started.
Test Case '-[SwaggerClientTests.UserAPITests test1CreateUser]' passed (0.614 seconds).
Test Case '-[SwaggerClientTests.UserAPITests test2GetUser]' started.
Test Case '-[SwaggerClientTests.UserAPITests test2GetUser]' passed (0.613 seconds).
Test Case '-[SwaggerClientTests.UserAPITests test3DeleteUser]' started.
Test Case '-[SwaggerClientTests.UserAPITests test3DeleteUser]' passed (0.614 seconds).
Test Case '-[SwaggerClientTests.UserAPITests testLogin]' started.
Test Case '-[SwaggerClientTests.UserAPITests testLogin]' passed (0.489 seconds).
Test Case '-[SwaggerClientTests.UserAPITests testLogout]' started.
Test Case '-[SwaggerClientTests.UserAPITests testLogout]' passed (0.440 seconds).
Test Suite 'UserAPITests' passed at 2016-02-11 09:09:16.325.
     Executed 5 tests, with 0 failures (0 unexpected) in 2.769 (2.773) seconds
Test Suite 'SwaggerClientTests.xctest' passed at 2016-02-11 09:09:16.325.
     Executed 11 tests, with 0 failures (0 unexpected) in 6.438 (6.448) seconds
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:09 min
[INFO] Finished at: 2016-02-11T09:09:16+08:00
[INFO] Final Memory: 11M/245M
[INFO] ------------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants