Adds default settings for the generated Swagger ruby client #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was having a bit of pain when first using the generated client, though I'm not entirely sure if this is the correct approach. I just noticed that when trying to make API requests I needed to call `Swagger.configure` before things would work, but then it would attempt to call the pets API instead of my API that I had just conusmed to generate the client.
|
@csaunders there's PR to organize the Ruby code into a module #662. Would that address or alleviate your concern ? |
This was referenced Mar 11, 2020
This was referenced Aug 17, 2021
This was referenced Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having a bit of pain when first using the generated client, though
I'm not entirely sure if this is the correct approach. I just noticed that
when trying to make API requests I needed to call
Swagger.configurebeforethings would work, but then it would attempt to call the pets API instead of
my API that I had just conusmed to generate the client.
This is just something that I observed while using the generated Ruby client. I see that you can pass in a block to
Swagger.configurethough much of the work there seems counter to the reason behind generating an API client.A concern I have with this approach is that it could result in some clobbering if an application is using multiple swagger clients. Perhaps the generated swagger clients should be name spaced to the API they are wrapping to protect against that?
I'd love to hear your thoughts.