Skip to content

[C#] Fix "object' type for response #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2015

Conversation

wing328
Copy link
Contributor

@wing328 wing328 commented May 22, 2015

To address #730

Tested with type set to object with and without $ref

fehguy added a commit that referenced this pull request May 23, 2015
[C#] Fix "object' type for response
@fehguy fehguy merged commit f4aee62 into swagger-api:develop_2.0 May 23, 2015
@boazsapir
Copy link

@wing328 I am trying to retest but when I use the generation code from branch develop_2.0, and generate my CSharp code, the following lines, in ApiClient.cs, do not compile:

  request.AddQueryParameter(param.Key, param.Value);

  return (Object) await restClient.ExecuteTaskAsync(request);

Looks like a mismatch with my RestSharp.dll version. I took the dll from here:
swagger-codegen/modules/swagger-codegen/src/main/resources/csharp

Which dll version should I use?

@wing328
Copy link
Contributor Author

wing328 commented Jun 9, 2015

@boazsapir do you have NuGet installed ? If yes, please get it via https://www.nuget.org/packages/RestSharp

@boazsapir
Copy link

ok I will install it

@wing328
Copy link
Contributor Author

wing328 commented Jun 10, 2015

https://github.com/restsharp/RestSharp/releases/tag/105.1.0

The latest release does not contain the updated DLL. I'll follow up with the owner of RestSharp. For the time being, please use NuGet.

@wing328
Copy link
Contributor Author

wing328 commented Jun 10, 2015

@boazsapir I've filed a PR to update the DLL to the latest version (obtained from NuGet).

Please still use NuGet to obtain the latest version of RestSharp as NuGet would get the DLL of RestSharp for different platforms/frameworks.

@boazsapir
Copy link

ok, I managed to retest. The case of inline object works ok.

@wing328
Copy link
Contributor Author

wing328 commented Jun 10, 2015

@boazsapir thanks for performing the test.

@wing328 wing328 deleted the csharp_fix_object_type branch January 22, 2016 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants